CB-8515 Support DefaultLanguage selection for Windows #59
Conversation
| function updatejsprojFile(config, jsProjFilePath) { | ||
| var defaultLocale = config.defaultLocale(); | ||
|
|
||
| if (defaultLocale) { |
There was a problem hiding this comment.
I think we should remove or set to default DefaultLanguage in case there is no config.defaultLocale().
|
if no locale is not found it uses the current default language which is en-us. Since that is already hardcoded in proj files I'm not re-setting it. removing might have some side effects. |
|
I meant if you changed locale in config.xml and then removed this settings it will continue pointing to the wrong previously used locale, not the default one. |
|
May be just use something like this |
|
But this is minor, so I'm +1 merging this. |
|
I'll fix the default locale to en-US. When a defaultlocale is not present we should set it to en-US. Good catch! |
|
This looks good! @sgrebnov Can you please help merge this one? It will be good to have this in the next cordova-windows release. |
|
This change is still not reflected in documentation in https://cordova.apache.org/docs/en/latest/config_ref/ (defaultlocale is shown as iOS-only) |
In apache/cordova-windows#59 `defaultlocale` was implemented for Windows.
|
Documentation change is PRd, please have a look at apache/cordova-docs#782 |
In apache/cordova-windows#59 `defaultlocale` was implemented for Windows.
Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" attribute.
Related JIRA: https://issues.apache.org/jira/browse/CB-8515