This repository has been archived by the owner on May 25, 2021. It is now read-only.
Drop logging level for "no record of user %s" #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning is tripped primarily when an admin is defined in local.ini and has no associated _users document. This can happen fairly often in development and testing setups, meaning that every other line in the logfile is "no record of user admin". The right thing to do here might be to check if the currently defined user is a local admin and only complain in that situation, but presently chttpd only directly depends on couch_auth_cache and to do so would require unencapsulating how couch_auth_cache handles ini file defined admin users vs. authentication database users, which feels wrong. Change suggested by @janl in #couchdb-dev IRC.
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning is tripped primarily when an admin is defined in local.ini
and has no associated _users document. This can happen fairly often in
development and testing setups, meaning that every other line in the
logfile is "no record of user admin".
The right thing to do here might be to check if the currently defined
user is a local admin and only complain in that situation, but presently
chttpd only directly depends on couch_auth_cache and to do so would
require unencapsulating how couch_auth_cache handles ini file defined
admin users vs. authentication database users, which feels wrong.
Change suggested by @janl in #couchdb-dev IRC.