add _changes?feed=stream sugar for continuous #28
Conversation
allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: apache/couchdb#307 apache#40 apache/couchdb-chttpd#28 closes COUCHDB-2237
robertkowalski
force-pushed
the
2237-stream
branch
from
53b35d9
to
03d047a
Compare
allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: apache/couchdb#307 apache/couchdb-couch#40 apache#28 closes COUCHDB-2237
PRs for the change: apache#307 apache/couchdb-couch#40 apache/couchdb-chttpd#28 COUCHDB-2237
| @@ -93,7 +93,7 @@ handle_changes_req1(#httpd{}=Req, Db) -> | |||
| couch_stats:decrement_counter([couchdb, httpd, clients_requesting_changes]) | |||
| end; | |||
| _ -> | |||
| Msg = <<"Supported `feed` types: normal, continuous, longpoll, eventsource">>, | |||
| Msg = <<"Supported `feed` types: normal, continuous/stream, longpoll, eventsource">>, | |||
There was a problem hiding this comment.
One thought just crossed my mind: don't you think, that continuous/stream could be misread by a user and they'll try to send a request with ?feed=continuous/stream parameter?
There was a problem hiding this comment.
in general a person can misread every information you present and in this case i would doubt that this happens often
how would you present the message?
There was a problem hiding this comment.
@daleharvey what do you think?
There was a problem hiding this comment.
normal, continuous, stream, longpoll, eventsource e.g. without making difference between continuous and stream since both are the valid options. All the questions "why" will be covered by the docs.
There was a problem hiding this comment.
I agree with @kxepal that stream should be listed like the other options.
I'm -0 on adding an alias for an existing feature (that is, I'd rather we didn't add more api without adding functionality, but I'm not blocking it).
There was a problem hiding this comment.
a bit of clarification, I most care about the error message being clear and I suggest we use @kxepal’s version, if we add the alias. I don’t advocate for or against the alias, but if others think, that it is a good idea, you should go ahead.
robertkowalski
force-pushed
the
2237-stream
branch
from
03d047a
to
faa3d9d
Compare
allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: apache/couchdb#307 apache/couchdb-couch#40 apache#28 closes COUCHDB-2237
|
thank you all for the input. fixed the error message. mind taking a second look @davisp? |
|
Hum, I changed the error message, but as nobody is really a fan of it (so far -0 and 0) and I am also unsure about it I am going to close this and will give Dale feedback. One thing left is that replication still uses continuous and stream would not be a good name for it. So I think we need to think about it more. Maybe we can change Thanks for all your feedback! |
PRs for the change: apache#307 apache/couchdb-couch#40 apache/couchdb-chttpd#28 COUCHDB-2237
robertkowalski
force-pushed
the
2237-stream
branch
from
faa3d9d
to
79322ef
Compare
allow `feed=live` as sugar for `continuous` which is hard to type. PRs for the change: apache/couchdb#307 apache/couchdb-couch#40 apache#28 closes COUCHDB-2237
allow `feed=live` as sugar for `continuous` which is hard to type. PouchDB already supports `live`. PRs for the change: apache/couchdb#307 apache#40 apache/couchdb-chttpd#28 closes COUCHDB-2237
allow `feed=live` as sugar for `continuous` which is hard to type. PouchDB already supports `live`. PRs for the change: apache/couchdb#307 apache/couchdb-couch#40 apache#28 closes COUCHDB-2237
robertkowalski
force-pushed
the
2237-stream
branch
from
79322ef
to
ef76d58
Compare
PRs for the change: #307 apache/couchdb-couch#40 apache/couchdb-chttpd#28 COUCHDB-2237
allow `feed=live` as sugar for `continuous` which is hard to type. PouchDB already supports `live`. PRs for the change: apache/couchdb#307 apache/couchdb-couch#40 #28 closes COUCHDB-2237
allow `feed=live` as sugar for `continuous` which is hard to type. PouchDB already supports `live`. PRs for the change: apache/couchdb#307 #40 apache/couchdb-chttpd#28 closes COUCHDB-2237
|
@robertkowalski ping (: |
|
feed=live already landed in couchdb-chttpd master, shouldn't this be closed now? |
|
thanks for the reminder - merged as ca0195f |
PRs for the change: apache#307 apache/couchdb-couch#40 apache/couchdb-chttpd#28 COUCHDB-2237
allow
feed=streamas sugar forcontinuouswhich is hard totype.
PRs for the change:
apache/couchdb#307
apache/couchdb-couch#40
#28
closes COUCHDB-2237