This repository has been archived by the owner on May 25, 2021. It is now read-only.
Handle errors from before_request/after_request #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring fixes the handling of errors from before_request. Unify how we deal with errors among before_request and handle_request.
| {exit, normal, [{mochiweb_request, send, _, _} | _]} -> | ||
| exit(normal); % Client disconnect (R15+) | ||
| {exit, normal, [{mochiweb_request, send, _} | _]} -> | ||
| exit(normal); % Client disconnect (R14) |
There was a problem hiding this comment.
You can drop this clause with the light on heart like we dropped R14 support.
|
Looks good for me, need to check however. |
|
Nice! +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring fixes the handling of errors from before_request.
Unify how we deal with errors among before_request and handle_request.