This repository has been archived by the owner on May 25, 2021. It is now read-only.
Validate boolean parameters in /_replicate payload #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests pass locally. +1 |
|
+1 |
|
@rnewson Why not to create a branch for 2.0 and prepare release from there while people still can work on new features and master? Sounds like gitflow-ish. |
|
Committers to couchdb should be focused on making 2.0 happen. If they want to do other, unrelated work, they can keep it elsewhere for now. |
asfgit
pushed a commit
that referenced
this pull request
Mar 14, 2017
httpc pool's terminate/2 can block up to 5 seconds in case when ssl sockets are used. Previously this was not an issue as replication jobs would run until completion and only exit once. With the scheduler, replication jobs are stopped regularly during rescheduling. So terminate/2 could be called `max_churn` number of times in a row during each reschedule cycle. This could lead to scheduler gen_server being blocked for up to 100 seconds at a time. To fix, unlink the connection and call stop in a separate process. This way, socket will get a chance to be closed properly, but if it doesn't, ibrowse client will kill it (this ensures connection processes won't leak).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
/_replicator, end-point/_replicatedoesn't check type for the boolean parameters in payload, which leads replicator to crash withcase_clause.This patch makes it to return "bad request" error on invalid input.
COUCHDB-3118