Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x support to CouchDB docker image #245

Merged

Conversation

kun-lu20
Copy link
Contributor

Overview

Since the s390x .deb binary on debian:bullseye is released from v3.3.2 afterwards and all pre-requisites mentioned in #67 (comment) are available now, this PR aims to add s390x support to CouchDB docker image.

Testing recommendations

https://github.com/apache/couchdb-docker#how-to-use-this-image
https://docs.couchdb.org/en/stable/intro/tour.html

I've built the multi-arch docker image on an Intel VM after applying the code change in this PR and verified the generated s390x image on a s390x VM. It worked fine.

GitHub issue number

#67

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

Signed-off-by: Kun-Lu <kun.lu@ibm.com>
@kun-lu20
Copy link
Contributor Author

Hi @nickva ,

Could you please take a look at this PR as well? Thank you so much!

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickva nickva merged commit b616800 into apache:main May 24, 2023
@nickva
Copy link
Contributor

nickva commented May 24, 2023

Thank you for your contribution, @kun-lu20!

@kun-lu20
Copy link
Contributor Author

Thanks @nickva !

@kun-lu20
Copy link
Contributor Author

Hi @nickva ,

Could you please update the following file as well, so that the docker official image of CouchDB v3.3.2+ can have s390x support?

https://github.com/docker-library/official-images/blob/bde595a716993f12b5bcd0476915b6bc0c17d3b4/library/couchdb#L10

Thank you so much!

@nickva
Copy link
Contributor

nickva commented May 30, 2023

@kun-lu20, sure thing, thanks for the reminder. I created a PR: docker-library/official-images#14752

@kun-lu20
Copy link
Contributor Author

Thanks @nickva !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants