This repository has been archived by the owner on May 25, 2021. It is now read-only.
Use meck:wait to fix race condition #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabric:update_docs is running in the context of a `read_repair` which is an independent process started using `erlang:spawn/1`. This leads to a race when we try to use `meck:history(fabric)`. Use of `meck:wait` ensures that we call `meck:history` after `fabric:update_docs` has been called.
|
+1 Nice. Didn't know about meck:wait. Could probably use it in other places where we have sleeps and race conditions. |
asfgit
pushed a commit
that referenced
this pull request
May 24, 2016
This closes #52 Signed-off-by: ILYA Khlopotov <iilyak@ca.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fabric:update_docs is running in the context of a
read_repairwhich is anindependent process started using
erlang:spawn/1. This leads to a racewhen we try to use
meck:history(fabric). Use ofmeck:waitensures thatwe call
meck:historyafterfabric:update_docshas been called.