Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stable and update parameter for views #1046

Merged
merged 9 commits into from
Mar 5, 2018

Conversation

popojargo
Copy link
Member

@popojargo popojargo commented Jan 13, 2018

Overview

Testing recommendations

GitHub issue number

#921

Related Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

Copy link
Contributor

@Antonio-Maranhao Antonio-Maranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popojargo it's giving me this warning in the console:

Warning: Failed prop type: Invalid prop `update` of type `boolean` supplied to `QueryOptions`, expected `string`.
    in QueryOptions (created by Connect(QueryOptions))
    in Connect(QueryOptions) (created by RightAllDocsHeader)
    in div (created by RightAllDocsHeader)
    in RightAllDocsHeader (created by TabsSidebarHeader)
...

Also, could you update showAsActive() in /addons/documents/index-results/components/queryoptions/QueryOptions.js to include your two new options. It should test if the parameter's value is different than its default, so the Query Options button is displayed as active (i.e. text in red).

@popojargo
Copy link
Member Author

@Antonio-Maranhao Fixed

@garrensmith
Copy link
Member

@Antonio-Maranhao some indenting issues on that. After that please merge

@garrensmith garrensmith merged commit 5e81931 into apache:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants