-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stable and update parameter for views #1046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@popojargo it's giving me this warning in the console:
Warning: Failed prop type: Invalid prop `update` of type `boolean` supplied to `QueryOptions`, expected `string`.
in QueryOptions (created by Connect(QueryOptions))
in Connect(QueryOptions) (created by RightAllDocsHeader)
in div (created by RightAllDocsHeader)
in RightAllDocsHeader (created by TabsSidebarHeader)
...
Also, could you update showAsActive()
in /addons/documents/index-results/components/queryoptions/QueryOptions.js
to include your two new options. It should test if the parameter's value is different than its default, so the Query Options button is displayed as active (i.e. text in red).
@Antonio-Maranhao Fixed |
@Antonio-Maranhao some indenting issues on that. After that please merge |
Overview
Testing recommendations
GitHub issue number
#921
Related Pull Requests
Checklist