Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace brace with ace-build and react-ace (#1331)" #1334

Merged

Conversation

Antonio-Maranhao
Copy link
Contributor

Overview

Syntax check in the Code Editor is not working with the new react-ace component introduced in PR. The issue only happens in the release build. The editor works correctly with the dev server.

This PR reverts back to using brace by reverting commit 9fc82fb until the release build can be fixed for react-ace.

Testing recommendations

Automated tests pass

GitHub issue number

n/a

Related Pull Requests

n/a

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

@Antonio-Maranhao Antonio-Maranhao merged commit 260f5f9 into apache:main Jan 31, 2022
@Antonio-Maranhao Antonio-Maranhao deleted the revert-react-ace-commit branch January 31, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants