Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in Nightwatch tests #1450

Merged

Conversation

Antonio-Maranhao
Copy link
Contributor

Overview

Fix syntax errors when calling Nightwatch execute() function.

Testing recommendations

Verify that errors like the one below are no longer printed:

>> Error
>>      Response 500 POST /session/00adc39b522f52a7247d46533b2f9bc4/execute/sync (19ms)
   {
     value: {
       error: 'javascript error',
       message: 'javascript error: Invalid left-hand side in assignment\n' +
         '  (Session info: chrome=125.0.6422.141)',
       stacktrace: ''
     }
  }

GitHub issue number

n/a

Related Pull Requests

n/a

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

@Antonio-Maranhao
Copy link
Contributor Author

Hi @big-r81, looks like your recent changes to .asf.yaml are preventing PRs from being merged. There are two issues:

  1. checks are not getting triggered for PRs like this one from a fork
  2. even then the checks run, they don't match the required names, like in Fix errors running Nightwatch's execute() #1451

Because of 2, I don't have permission to merge a fix. Could you please look into addressing this?

@big-r81
Copy link
Contributor

big-r81 commented Jun 3, 2024

@Antonio-Maranhao I am currently trying to solve the problem...

@big-r81 big-r81 force-pushed the fix-errors-nightwatch-tests branch from 0c5b091 to f160115 Compare June 3, 2024 21:19
@big-r81
Copy link
Contributor

big-r81 commented Jun 3, 2024

@Antonio-Maranhao Should be fixed now, but it seems you need to re-run your "personal" gh action ...

@big-r81 big-r81 force-pushed the fix-errors-nightwatch-tests branch from f160115 to 2817aba Compare June 3, 2024 22:23
@Antonio-Maranhao
Copy link
Contributor Author

Thanks for the quick action on this @big-r81. Much appreciated.

@big-r81
Copy link
Contributor

big-r81 commented Jun 3, 2024

@Antonio-Maranhao Checks are working now and are run when opening a PR against main. Now you can choose wheter to merge this PR or #1451.

@Antonio-Maranhao Antonio-Maranhao merged commit 6e19267 into apache:main Jun 4, 2024
3 checks passed
@Antonio-Maranhao Antonio-Maranhao deleted the fix-errors-nightwatch-tests branch June 4, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants