Replication page update #669

benkeen · 2016-03-16T21:07:00Z

This PR refactors the replication page for a simpler wizard-like structure. Advanced replication options are coming down the pipe in a different PR.

Replication scenarios now working:

local -> new local db 
local -> existing local db
local -> new remote db
local -> existing remote db
remote -> remote new DB
remote -> remote existing DB
remote -> new local db
remote -> existing local db

Yaaaaaaaayyyyyyyyy.

benkeen · 2016-07-04T15:40:07Z

Hey @justin-mcdavid-ibm, thanks for the feedback. Mind taking a look at this PR and seeing what you think? All feedback has been done (see below), except for this one:

A source database that is open to/readable by the public does not require $USERNAME and $PASSWORD in its URL, right?

Yeah you're right. I was able to replicate a publicly available db without specifying credentials. What do you suggest for the help blurb? Right now it explicitly mentioned creds.(https://$REMOTE_USERNAME:$REMOTE_PASSWORD@$REMOTE_SERVER/$DATABASE).

Done

The replicate button activates after fields have been clicked on, but not before information is actually entered. Can we have the replication button activate only after the fields are populated? +1
Text on the replication button should be “Start Replication”
Increase the widths of all dropdowns
The in-field explanatory text for Remote Sources and Targets should be https://$REMOTE_USERNAME:$REMOTE_PASSWORD@$REMOTE_SERVER/$DATABASE -
Can we leave the replication button inactive if the DB listed as an existing local source doesn’t actually exist? I can enter an db that doesn’t exist and still trigger replication. Same for non-existing local targets.
There doesn’t appear to be any checking for the pre-existence of a “new” database. I selected “new local database,” and used the same DB for source and target. Can we put in check in to make sure that users aren’t accidentally overwriting existing DBs? I’m assuming that there are back-end safeguards, but my test-replication job didn’t throw any errors.

justinmcdavid · 2016-07-15T20:06:18Z

Hey Ben,

I'm testing this, and it's awesome. Great work on this. It's a big improvement.

There are a couple of things I'm seeing that we probably should tweak.

The "Select source" and "Select target" in-field explanatory test should be gray, though values selected through those dropdowns should remain the color of regular text.

When you specify a custom replication doc ID, it has to be a new ID (folks might think they can specify an existing doc-- which causes a conflict), so we should elaborate on the explanatory text as [Custom, new ID (optional)]. Also, because you can't use the same custom ID for multiple jobs, can we add a clear (x) inside the custom ID field, so that after starting a replication job, users can easily clear just that field if they're reusing selected dbs or remote creds?

If possible, we should remove the verification step where the account password is entered. I'm not sure why it's a requirement. If we do keep it, the button should be "Start Replication" rather than "Continue Replication," and we should specify which password is required, because it could be interpreted as a remote account's password.

Icing, but after selecting from a dropdown, can we make focus automatically change to the following object?

If there are illegal characters (spaces, prohibited symbols), or if the db name starts with something other than a lower-case letter in new-database-name field, can we disable the replicate button? I was able to "trigger" a replication from a local db to a new one called "spa ces" which then failed.

Thanks for your work on this.

benkeen · 2016-07-20T04:08:24Z

Thanks @justin-mcdavid-ibm! Just emailed you - sorry, didn't realize you responded here.

benkeen · 2016-07-24T04:14:48Z

Hey @garrensmith / @robertkowalski - took a thousand years, but could I get one of you to review this sucker? Hope all is well on your ends.

garrensmith · 2016-07-25T09:33:19Z

app/addons/auth/actions.js

-    });
-    promise.fail(errorHandler);
-  },
+  promise.done(function () {


promise.done should be promise.then that is more semantic.

garrensmith · 2016-07-25T10:37:42Z

Hey @benkeen this is making good progress. The basic functionality looks great. Just some code clean ups needed. We will need some nightwatch tests before we can merge this in.

benkeen · 2016-07-26T02:29:10Z

Nice, thanks @garrensmith!

robertkowalski · 2016-07-26T11:06:11Z

app/addons/components/react-components.react.jsx

+  },
+
+  updateTypeahead: function () {
+    $(ReactDOM.findDOMNode(this.refs.field)).typeahead({


we are removing the jquery typeahed and are using react-select instead.

it is very easy to integrate, here is an example: https://github.com/apache/couchdb-fauxton/blob/5be261085761c5f1d0510f2d28117775ea3e0da2/app/addons/documents/components/jumptodoc.react.jsx

robertkowalski · 2016-07-26T11:09:12Z

good work! agree with garren on smaller components.

using const would be great

MIT license. https://github.com/mathiasbynens/base64

benkeen · 2016-08-01T01:44:43Z

Thanks again for the feedback, guys. All fixed up except for the NW test. @garrensmith did you ever get NW running locally? Not sure what I'm missing but I get a "Connection refused! Is selenium server started?" error when running grunt nightwatch locally.

garrensmith · 2016-08-01T08:56:57Z

Hey @benkeen, yes its working. We have changed how it works though. It now runs through docker. So you need to install docker. See here and here

garrensmith · 2016-08-01T09:15:03Z

app/addons/auth/actions.js

+    }
+    FauxtonAPI.navigate('/');
+  });
+  promise.fail(errorHandler);


This needs to be changed to the .then

benkeen · 2016-08-01T23:49:37Z

Too cool about Docker. Sheesh! Step away for 2 months and all this activity happens when you're gone. Can't say I approve! ;)

benkeen · 2016-08-15T00:49:40Z

Hey @robertkowalski or @garrensmith, I think I need an extra pair of eyes on this. This ticket has dragged onnnnn and on and I have supremely limited time to work on it. I just can't get the NW tests to run reliably. Running just the one replication.js file works fine both locally & on travis, but when running all of them, it fails every time on Travis. Possibly it's actually a couch error silently failing to create the new replicated DB...? Maybe you can see something I can't.

I left all the debugging code in.

garrensmith · 2016-08-15T13:10:14Z

@benkeen you have done an awesome job. Thanks. I can take a look. I can replicate the failing test locally. I'll try and fix it.

garrensmith · 2016-08-15T13:46:07Z

@benkeen I've continuing the work in #761

garrensmith · 2017-02-23T07:08:11Z

@benkeen this worked was merged in with the other PR. Could you close this PR.

benkeen · 2017-02-23T15:07:32Z

No problem. Hope all's going well, @garrensmith!

benkeen force-pushed the replication-page-update branch from 3d632e0 to 97f1171 Compare March 30, 2016 22:37

benkeen force-pushed the replication-page-update branch from 5ab3b92 to f4079ab Compare April 14, 2016 21:02

benkeen force-pushed the replication-page-update branch 3 times, most recently from 8a897c3 to 51fe845 Compare June 8, 2016 09:43

benkeen force-pushed the replication-page-update branch 2 times, most recently from ed459f6 to e4943f8 Compare July 12, 2016 02:50

benkeen force-pushed the replication-page-update branch 4 times, most recently from 4782891 to 6ee4d60 Compare July 24, 2016 03:11

benkeen changed the title ~~[WIP] Replication page update~~ Replication page update Jul 24, 2016

benkeen force-pushed the replication-page-update branch from 6ee4d60 to b357fd4 Compare July 24, 2016 03:50

garrensmith reviewed Jul 25, 2016
View reviewed changes

benkeen force-pushed the replication-page-update branch from 6610123 to b4bcf38 Compare July 26, 2016 02:46

robertkowalski reviewed Jul 26, 2016
View reviewed changes

Include base64 npm module

0aff2b9

MIT license. https://github.com/mathiasbynens/base64

benkeen force-pushed the replication-page-update branch 2 times, most recently from 3639c15 to 2830341 Compare July 31, 2016 22:57

garrensmith reviewed Aug 1, 2016
View reviewed changes

app/addons/auth/actions.js

}

FauxtonAPI.navigate('/');

});

promise.fail(errorHandler);

Copy link

Member

garrensmith Aug 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed to the .then

benkeen force-pushed the replication-page-update branch 2 times, most recently from 34d462a to b974110 Compare August 14, 2016 20:29

benkeen added 12 commits August 14, 2016 13:32

Replication page update

b974110

debug

1e6544b

debugging

e70f83a

sheesh

dd91f0e

k

7a40e6e

continued

d5655d1

more

10c6314

I miss my Sunday

804eda7

more

f91dd99

all tests

50bedff

meh

6b693e5

testing cache bust

efd3677

garrensmith mentioned this pull request Aug 15, 2016

New replication #761

Closed

benkeen closed this Feb 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replication page update #669

Replication page update #669

benkeen commented Mar 16, 2016 •

edited

benkeen commented Jul 4, 2016 •

edited

justinmcdavid commented Jul 15, 2016

benkeen commented Jul 20, 2016

benkeen commented Jul 24, 2016

garrensmith Jul 25, 2016

garrensmith commented Jul 25, 2016

benkeen commented Jul 26, 2016

robertkowalski Jul 26, 2016

robertkowalski commented Jul 26, 2016

benkeen commented Aug 1, 2016

garrensmith commented Aug 1, 2016 •

edited

garrensmith Aug 1, 2016

benkeen commented Aug 1, 2016

benkeen commented Aug 15, 2016

garrensmith commented Aug 15, 2016

garrensmith commented Aug 15, 2016

garrensmith commented Feb 23, 2017

benkeen commented Feb 23, 2017

Replication page update #669

Replication page update #669

Conversation

benkeen commented Mar 16, 2016 • edited

benkeen commented Jul 4, 2016 • edited

Done

justinmcdavid commented Jul 15, 2016

benkeen commented Jul 20, 2016

benkeen commented Jul 24, 2016

garrensmith Jul 25, 2016

Choose a reason for hiding this comment

garrensmith commented Jul 25, 2016

benkeen commented Jul 26, 2016

robertkowalski Jul 26, 2016

Choose a reason for hiding this comment

robertkowalski commented Jul 26, 2016

benkeen commented Aug 1, 2016

garrensmith commented Aug 1, 2016 • edited

garrensmith Aug 1, 2016

Choose a reason for hiding this comment

benkeen commented Aug 1, 2016

benkeen commented Aug 15, 2016

garrensmith commented Aug 15, 2016

garrensmith commented Aug 15, 2016

garrensmith commented Feb 23, 2017

benkeen commented Feb 23, 2017

benkeen commented Mar 16, 2016 •

edited

benkeen commented Jul 4, 2016 •

edited

garrensmith commented Aug 1, 2016 •

edited