-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactify #820
Reactify #820
Conversation
This removes the last parts of backbone.layout manager. We now have a single React entry point.
This is pretty cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so great! <3
+1 after deleting commented stuff
const toggleMenu = sinon.spy(); | ||
const burgerEl = mount(<Views.Burger toggleMenu={toggleMenu} />); | ||
burgerEl.simulate('click'); | ||
//TestUtils.Simulate.click(ReactDOM.findDOMNode(burgerEl)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
args.splice(0, 1, eventName, this); | ||
broadcaster.trigger.apply(broadcaster, args); | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pure joy!
authPromise = FauxtonAPI.auth.checkAccess(roles); | ||
routeUrls.forEach(route => { | ||
this.route(route, route.toString(), (...args) => { | ||
//const args = Array.prototype.slice.call(arguments), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete comment
<% if (development) {%> | ||
<script src="/templates.js" type="text/javascript"></script> | ||
<%}%> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally! :)
+1 |
merged! |
This removes the last parts of backbone.layout manager. We now have a single React entry point. PR: apache#820 PR-URL: apache#820 Reviewed-By: Robert Kowalski <rok@kowalski.gd>
No description provided.