handle username and passwords correctly with base64 encoding #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millayr
reviewed
Feb 22, 2017
| const rawCreds = url.slice(startIndex, index); | ||
| const colonIndex = rawCreds.indexOf(':'); | ||
| const username = rawCreds.slice(0, colonIndex); | ||
| const password = rawCreds.slice(colonIndex + 1, rawCreds.length); |
There was a problem hiding this comment.
Minor note but I think you could combine all of these variable instantiations and assignments in to a single const statement.
millayr
reviewed
Feb 22, 2017
app/addons/replication/api.js
Outdated
| return url; | ||
| } | ||
|
|
||
| const protocal = url.startsWith("https") ? "https://" : 'http://'; |
|
+1 |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.