Generate a unique Erlang cookie by default #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relies on new support for the COUCHDB_ERLANG_COOKIE env to generate a Secret that is written down into ~/.erlang.cookie instead of passing the cookie in the ERL_FLAGS. I suppose it would be possible to merge the generated cookie into ERL_FLAGS, but this approach seemed cleaner and more maintainable going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This relies on new support for the
COUCHDB_ERLANG_COOKIEenv to generate a Secret that is written down into ~/.erlang.cookie instead of passing the cookie in theERL_FLAGS. I suppose it would be possible to merge the generated cookie into ERL_FLAGS, but this approach seemed cleaner, more secure, and more maintainable going forward.Special notes for your reviewer:
Will publish the update chart separately, right now I'd like to merge this in part to test a fix for #67 and see if we can get versions up through 3.6.0 published.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.