This repository has been archived by the owner on May 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for the test runner.
Prevents annoying npm warning.
Oops, looks like Robert caught the dev dep issue in: |
+1 thank you! :) i'll close my PR |
you can close the pr now (we can't) thanks again! |
thanks @tmpfs for this. This is awesome. |
Great, nice one for merging promptly :) I've got 2.0alpha running up nice and quickly thanks to Docker, I must say a much better experience than previously building from source which as you know was fraught with issues (spidermonkey dep etc.). Great job! Got the tests up and running, would be good to get a decision on the issue regarding whether to require node 4 as that has a big impact on how we move forward. I can look into the stack traces referenced in: After we get a decision on #41 if you like? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes: