Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Housekeeping #23

Closed
wants to merge 4 commits into from
Closed

Housekeeping #23

wants to merge 4 commits into from

Conversation

tmpfs
Copy link
Contributor

@tmpfs tmpfs commented Jan 14, 2016

Some minor changes:

  • Add missing babel-register dev dependency (required for test execution)
  • Prevent npm warning on license field
  • Note the required node version in the readme

@tmpfs
Copy link
Contributor Author

tmpfs commented Jan 14, 2016

Oops, looks like Robert caught the dev dep issue in:

#19

@robertkowalski
Copy link
Contributor

+1 thank you! :)

i'll close my PR

asfgit pushed a commit that referenced this pull request Jan 14, 2016
Required for the test runner.

PR: #23
PR-URL: #23
Reviewed-By: Robert Kowalski <rok@kowalski.gd>
asfgit pushed a commit that referenced this pull request Jan 14, 2016
Prevents annoying npm warning.

PR: #23
PR-URL: #23
Reviewed-By: Robert Kowalski <rok@kowalski.gd>
asfgit pushed a commit that referenced this pull request Jan 14, 2016
PR: #23
PR-URL: #23
Reviewed-By: Robert Kowalski <rok@kowalski.gd>
asfgit pushed a commit that referenced this pull request Jan 14, 2016
PR: #23
PR-URL: #23
Reviewed-By: Robert Kowalski <rok@kowalski.gd>
@robertkowalski
Copy link
Contributor

you can close the pr now (we can't)

thanks again!

@garrensmith
Copy link
Member

thanks @tmpfs for this. This is awesome.

@tmpfs
Copy link
Contributor Author

tmpfs commented Jan 14, 2016

Great, nice one for merging promptly :)

I've got 2.0alpha running up nice and quickly thanks to Docker, I must say a much better experience than previously building from source which as you know was fraught with issues (spidermonkey dep etc.). Great job! Got the tests up and running, would be good to get a decision on the issue regarding whether to require node 4 as that has a big impact on how we move forward.

robertkowalski/nmo#41

I can look into the stack traces referenced in:

robertkowalski/nmo#45

After we get a decision on #41 if you like?

@tmpfs tmpfs closed this Jan 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants