-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: prometheus counter metric naming (#4474)
`couch_prometheus_util:counter_metric/1` is intended to add a `_total` suffix to the name of metrics with type `counter` if the name does not already end with `_total`. The implementation was previously incorrect, resulting in metrics with names like `document_purges_total_total`. This adds basic eunit tests for the failure / success scenarios and fixes the implementation. It is a breaking change for consumers of the `_node/_local/_prometheus` endpoint, however, since the following metric is renamed: * `couchdb_document_purges_total_total` -> `couchdb_document_purges_total`
- Loading branch information
1 parent
5cdc0aa
commit 0aedd93
Showing
2 changed files
with
77 additions
and
73 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 0 additions & 70 deletions
70
src/couch_prometheus/test/eunit/couch_prometheus_util_tests.erl
This file was deleted.
Oops, something went wrong.