Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: avoid dropping attachment chunks on quorum writes
This only applies to databases that have an n > [cluster] n. Our `middleman()` function that proxies attachment streams from the incoming HTTP socket on the coordinating node to the target shard-bearing nodes used the server config to determine whether it should start dropping chunks from the stream. If a database was created with a larger `n`, the `middleman()` function could have started to drop attachment chunks before all attached nodes had a chance to receive it. This fix uses a database’s concrete `n` value rather than the server config default value. Co-Authored-By: James Coglan <jcoglan@gmail.com> Co-Authored-By: Robert Newson <rnewson@apache.org>
- Loading branch information
1 parent
4262714
commit 9b30ada
Showing
3 changed files
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters