Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jenkins #1632

Closed
wohali opened this issue Sep 29, 2018 · 3 comments
Closed

Fix Jenkins #1632

wohali opened this issue Sep 29, 2018 · 3 comments
Milestone

Comments

@wohali
Copy link
Member

wohali commented Sep 29, 2018

3x builds are failing on Jenkins.

2 of them are because of changed lintian rules in Debian for packages.

1 of them is because dev/run got changed in a way that makes it not work for Python 3.

Ideally, run thru all of the Python scripts and make them run under Python 3.

@wohali wohali added this to the 2.3.0 milestone Sep 29, 2018
@nickva
Copy link
Contributor

nickva commented Oct 1, 2018

Oops, my bad, I am sorry. It was probably this commit:

fbb5588

Should we make it python3 or revert it?

@wohali
Copy link
Member Author

wohali commented Oct 1, 2018

@nickva

The naughty thing that I had to do was, in the CentOS 6 Docker image, I installed python3 to /usr/local/bin/python and placed /usr/local/bin ahead of /usr/bin in the path. This is because CentOS 6 has Python 2.6, which is too old for some of the things we're doing in our code already...and I took great pains to ensure that all of the Python scripts we run in make check and make release and make dist work without change in both python 2 and python 3.

What I'd do is run 2to3 on all 4 scripts, and apply any changes it requests, then change it to python3. That'll be better for the future, when the distros decide to remove python 2.7 anyway. The error we're getting on Jenkins for CentOS6 for Python 3 is:

make[1]: Entering directory `/tmp/tmp.ILBeu2AdWN/apache-couchdb-2.2.0-fbb5588'
Traceback (most recent call last):
  File "dev/run", line 592, in <module>
    main()
  File "dev/run", line 80, in main
    ctx = setup()
  File "dev/run", line 94, in setup
    setup_configs(ctx)
  File "dev/run", line 65, in wrapper
    res = func(*args, **kwargs)
  File "dev/run", line 203, in setup_configs
    write_config(ctx, node, env)
  File "dev/run", line 239, in write_config
    content = hack_default_ini(ctx, node, content)
  File "dev/run", line 289, in hack_default_ini
    flags=re.MULTILINE)
TypeError: sub() got an unexpected keyword argument 'flags'

nickva added a commit to cloudant/couchdb that referenced this issue Oct 3, 2018
Ran 2to3 and fixed a few deprecated warnings

Issue apache#1632
nickva added a commit to cloudant/couchdb that referenced this issue Oct 3, 2018
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue apache#1632
nickva added a commit to apache/couchdb-ci that referenced this issue Oct 3, 2018
@wohali
Copy link
Member Author

wohali commented Nov 7, 2018

Jenkins is working now - despite this issue - thanks to working around at the VM level.

We still want to get the Python 2/3 thing sorted out.

@wohali wohali closed this as completed Nov 7, 2018
nickva added a commit to cloudant/couchdb that referenced this issue Nov 14, 2018
Ran 2to3 and fixed a few deprecated warnings

Issue apache#1632
nickva added a commit to apache/couchdb-ci that referenced this issue Nov 14, 2018
nickva added a commit to apache/couchdb-ci that referenced this issue Nov 14, 2018
nickva added a commit to apache/couchdb-ci that referenced this issue Nov 14, 2018
nickva added a commit to apache/couchdb-ci that referenced this issue Nov 15, 2018
nickva added a commit to cloudant/couchdb that referenced this issue Nov 26, 2018
Ran 2to3 and fixed a few deprecated warnings

Issue apache#1632
nickva added a commit to cloudant/couchdb that referenced this issue Nov 26, 2018
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue apache#1632
nickva added a commit to cloudant/couchdb that referenced this issue Nov 26, 2018
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue apache#1632
nickva added a commit that referenced this issue Nov 26, 2018
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue #1632
nickva added a commit that referenced this issue Nov 26, 2018
Ran 2to3 and fixed a few deprecated warnings

Issue #1632
nickva added a commit that referenced this issue Nov 26, 2018
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue #1632
nickva added a commit that referenced this issue Nov 26, 2018
Ran 2to3 and fixed a few deprecated warnings

Issue #1632
nickva added a commit that referenced this issue Nov 26, 2018
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue #1632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants