fix: avoid dropping attachment chunks on quorum writes #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only applies to databases that have an n > [cluster] n. Our `middleman()` function that proxies attachment streams from the incoming HTTP socket on the coordinating node to the target shard-bearing nodes used the server config to determine whether it should start dropping chunks from the stream. If a database was created with a larger `n`, the `middleman()` function could have started to drop attachment chunks before all attached nodes had a chance to receive it. This fix uses a database’s concrete `n` value rather than the server config default value. Co-Authored-By: James Coglan <jcoglan@gmail.com> Co-Authored-By: Robert Newson <rnewson@apache.org>
janl
force-pushed
the
fix/attachment-writers-larger-n
branch
from
261b90a
to
9b30ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only applies to databases that have an
n > [cluster] n.Our
middleman()function that proxies attachment streams fromthe incoming HTTP socket on the coordinating node to the target
shard-bearing nodes used the server config to determine whether
it should start dropping chunks from the stream.
If a database was created with a larger
n, themiddleman()function could have started to drop attachment chunks before
all attached nodes had a chance to receive it.
This fix uses a database’s concrete
nvalue rather than theserver config default value.
Co-Authored-By: James Coglan jcoglan@gmail.com
Co-Authored-By: Robert Newson rnewson@apache.org