Make remsh work with quoted cookie

[jiahuili430]

Overview

Allow space and other special characters in cookies.

Testing recommendations

First set the cookie in vm.args, then run the script below:
e.g.: -setcookie 'a b\n\t\xd#{}()[]$&^!-=+?|//c\\d\\\e\\\\f'
or -setcookie "a b\n\t\xd#{}()[]$&^!-=+?|//c\\d\\\e\\\\f"

make release
cd rel/couchdb
./bin/couchdb
./bin/remsh

Related Issues or Pull Requests

fix #4405

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• Documentation changes were made in the src/docs folder
• Documentation changes were backported (separated PR) to affected branches

[iilyak]

I was testing this before the code was updated.

#!/bin/bash
COOKIE=$(echo "$ERL_FLAGS" | sed -E '
s/.*-setcookie[ ]*["]([^"]*)["].*/\1/;
s/.*-setcookie[ ]*([^ ]*).*/\1/;
')

echo "COOKIE='${COOKIE}'"

ERL_FLAGS_CLEAN=$(echo "$ERL_FLAGS" | sed -E '
s/-setcookie[ ]*[^"]*.*["]//
s/-setcookie[ ]*[^ ]*//
s/-name[ ]*[^ ]*//
')

echo "ERL_FLAGS_CLEAN='${ERL_FLAGS_CLEAN}'"

bash-3.2$ ERL_FLAGS='ddd -setcookie "secret  123" -name node1@mydomain.com hello' ./test
COOKIE='secret  123'
ERL_FLAGS_CLEAN='ddd secret  123"  hello'
bash-3.2$ micro test
bash-3.2$ ERL_FLAGS='ddd -setcookie "secret  123" -name node1@mydomain.com hello' ./test
COOKIE='secret  123'
ERL_FLAGS_CLEAN='ddd secret  123"  hello'
bash-3.2$ ERL_FLAGS='ddd -setcookie "secret  123" -name node1@mydomain.com hello' ./test
COOKIE='secret  123'
ERL_FLAGS_CLEAN='ddd secret  123"  hello'
bash-3.2$ micro test
bash-3.2$ ERL_FLAGS='ddd -setcookie "secret  123" -name node1@mydomain.com hello' ./test
COOKIE='secret  123'
ERL_FLAGS_CLEAN='ddd   hello'
bash-3.2$ ERL_FLAGS='ddd -setcookie "secret  123"' ./test
COOKIE='secret  123'
ERL_FLAGS_CLEAN='ddd '
bash-3.2$ ERL_FLAGS='ddd -setcookie "secret" -name node1@mydomain.com hello' ./test
COOKIE='secret'
ERL_FLAGS_CLEAN='ddd   hello'
bash-3.2$ ERL_FLAGS='ddd -setcookie "secret"' ./test
COOKIE='secret'
ERL_FLAGS_CLEAN='ddd '
bash-3.2$ ERL_FLAGS='ddd -setcookie secret -name node1@mydomain.com hello' ./test
COOKIE='secret'
ERL_FLAGS_CLEAN='ddd   hello'
bash-3.2$ ERL_FLAGS='ddd -setcookie secret' ./test
COOKIE='secret'
ERL_FLAGS_CLEAN='ddd '

[jiahuili430]

sed -E / sed -r is very powerful and helped me remove the if statement. Thank you!

[nickva]

-E/-r looks great. Good find, Ilya! It makes the expression easier to read and understand.

Is there a difference between -E and -r I checked man sed on macos and freebsd and both seem to have both options and say:

-r	     Same as -E	for compatibility with GNU sed.

[nickva]

It looks like our oldest Linux CentOS 7 doesn't support sed -E would we be able to use -r only?

[root@2dfb04f0d80c /]# sed --help
Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]...

  -n, --quiet, --silent
                 suppress automatic printing of pattern space
  -e script, --expression=script
                 add the script to the commands to be executed
  -f script-file, --file=script-file
                 add the contents of script-file to the commands to be executed
  --follow-symlinks
                 follow symlinks when processing in place
  -i[SUFFIX], --in-place[=SUFFIX]
                 edit files in place (makes backup if SUFFIX supplied)
  -c, --copy
                 use copy instead of rename when shuffling files in -i mode
  -b, --binary
                 does nothing; for compatibility with WIN32/CYGWIN/MSDOS/EMX (
                 open files in binary mode (CR+LFs are not treated specially))
  -l N, --line-length=N
                 specify the desired line-wrap length for the `l' command
  --posix
                 disable all GNU extensions.
  -r, --regexp-extended
                 use extended regular expressions in the script.
  -s, --separate
                 consider files as separate rather than as a single continuous
                 long stream.
  -u, --unbuffered
                 load minimal amounts of data from the input files and flush
                 the output buffers more often
  -z, --null-data
                 separate lines by NUL characters
  --help
                 display this help and exit
  --version
                 output version information and exit
...

[jiahuili430]

Changed them to sed -r, thanks for double-checking with different systems, Nick.

[nickva]

+1

ERL_FLAGS:

% export COUCHDB_COOKIE='a\t{}()[]$&^!-=+?|//c\\d\\\e\\\\f'
% export ERL_FLAGS="-setcookie ${COUCHDB_COOKIE}"
% ./bin/remsh
(remsh34975@127.0.0.1)1> erlang:get_cookie().
'a\t{}()[]$&^!-=+?|//c\\d\\\\e\\\\f'

vm.args:

-setcookie 'x b\n\t\xd#{}()[]$&^!-=+?|//c\\d\\\e\\\\f'

./bin/remsh
Erlang/OTP 24 [erts-12.3.2.9] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit]

Eshell V12.3.2.9  (abort with ^G)
(couchdb@127.0.0.1)1> erlang:get_cookie().
'x b\\n\\t\\xd#{}()[]$&^!-=+?|//c\\\\d\\\\\\e\\\\\\\\f'

Well done @jiahuili430. Thanks for nice tip about -r @iilyak !