Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more reliable password scheme tests #1250

Merged
merged 1 commit into from
Mar 28, 2018
Merged

fix: more reliable password scheme tests #1250

merged 1 commit into from
Mar 28, 2018

Conversation

janl
Copy link
Member

@janl janl commented Mar 28, 2018

Closes #1238

  1. log errors from waitForSuccess
  2. log errors in testFun()
  3. spinloop replaces arbitrary wait timeout

@janl
fix: more reliable password scheme tests
e66780e 
Closes apache#1238

1. log errors from waitForSuccess
2. log errors in testFun()
3. spinloop replaces arbitrary wait timeout
@janl janl requested review from wohali and eiri March 28, 2018 13:16
@janl janl mentioned this pull request Mar 28, 2018
Closed
@janl janl added this to the 2.2.0 milestone Mar 28, 2018
eiri
eiri approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@eiri eiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Unless I'm dead wrong on the root cause this should fix the problem and in any case I waitForSuccess is much better, than arbitrary delay.

@janl janl merged commit 0074b4f into apache:master Mar 28, 2018
@janl
Copy link
Member Author

janl commented Mar 28, 2018

thanks!

@janl janl deleted the test/improve-bcrypt-test branch March 28, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiri eiri eiri approved these changes

@wohali wohali Awaiting requested review from wohali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janl @eiri