Fix shard substitution in changes feeds #1251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSE changed the local_tree's join function so we need to update this. Previously we read _local docs out of the btree that ended up just giving us {DocId, {RevId, {BodyProps}}} to our callback. PSE changed things such that we now use couch_db:fold_local_docs which provides
#doc
records.Shard substitution happens when a changes feed is provided with a since_seq that references a ndoe that does not or has errored out some how. The substitution then goes and looks for an internal replication document so that we don't have to rewrind the changes feed entirely (i.e., we look at the internal replication checkpoint and can rewind to the place where the node-being-replaced last sent us documents).