Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore local nodes in read repair filtering #1613

Merged
merged 1 commit into from Sep 19, 2018

Commits on Sep 19, 2018

  1. Ignore local nodes in read repair filtering

    Previosly local node revisions were causing `badmatch` failures in read repair
    filter. Node sequences already filtered out local nodes while NodeRevs didn't, so
    during matching `{Node, NodeSeq} = lists:keyfind(Node, 1, NodeSeqs)` Node would
    not be found in the list and crash.
    
    Example of crash:
    
    ```
    fabric_rpc:update_docs/3 error:{badmatch,false}
     [{fabric_rpc,'-read_repair_filter/3-fun-1-',4,[{file,"src/fabric_rpc.erl"},{line,360}]},
    ```
    nickva committed Sep 19, 2018
    Copy the full SHA
    ceca9cb View commit details
    Browse the repository at this point in the history