Explicit Python version in scripts #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent Linux distributions start defaulting to Python 3, and require
ambiguous scripts to be more explicit.
For example building for Fedora 30 (not released yet) fails with:
ERROR: ambiguous python shebang in /opt/couchdb/bin/couchup:
#!/usr/bin/env python. Change it to python3 (or python2) explicitly.
So this commit changes the four Python scripts to use `python2`.
Note: They seem to be Python-3-compatible, but I couldn't be sure. If
you know they are, please tell me, I'll change it to `python3`.
adrienverge
force-pushed
the
fix/explicit-python2
branch
from
4307db0
to
5085aa1
Compare
adrienverge
added a commit
to adrienverge/copr-couchdb
that referenced
this pull request
Sep 25, 2018
adrienverge
added a commit
to adrienverge/copr-couchdb
that referenced
this pull request
Sep 25, 2018
|
@adrienverge I'm having to revert the change to Once @nickva 's PR lands, |
|
@wohali thanks for letting me know! I'm glad to ear that Python 3 support is on its way 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Linux distributions start defaulting to Python 3, and require
ambiguous scripts to be more explicit.
For example building for Fedora 30 (not released yet) fails with:
So this commit changes the four Python scripts to use
python2.Note: They seem to be Python-3-compatible, but I couldn't be sure. If
you know they are, please tell me, I'll change it to
python3.