Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose is_systemdb_name #1668

Merged
merged 1 commit into from
Oct 23, 2018
Merged

expose is_systemdb_name #1668

merged 1 commit into from
Oct 23, 2018

Conversation

garrensmith
Copy link
Member

Overview

Based off of aa63804
I want to expose a function we can use in multiple places that is a good check if a binary field is a system db. Once this is merged I want to use it in the partition feature branch.

Testing recommendations

All Current tests should pass

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;

@rnewson
Copy link
Member

rnewson commented Oct 19, 2018

is_system_db_name is my suggestion for a better name. This function only tests the name, after all. The other function is_system_db only tests #db{} records, so the two names are distinct and complementary.

@rnewson
Copy link
Member

rnewson commented Oct 19, 2018

is_valid_systemdb is not distinct from is_systemdb, this doesn't seem a helpful name (not least because it won't detect all valid system dbs).

@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

6 similar comments
@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

@garrensmith garrensmith changed the title expose is_valid_systemdb expose is_systemdb_name Oct 22, 2018
@rnewson
Copy link
Member

rnewson commented Oct 22, 2018

+1 but please update title and commit message to match.

Expose is_system_db_name as a way to verify if a binary string is the
name of a system database.
@garrensmith garrensmith merged commit d02d614 into apache:master Oct 23, 2018
@garrensmith garrensmith deleted the expose-is-valid-systemdb branch December 12, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants