Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating node local _replicator db #2251

Merged
merged 1 commit into from Oct 10, 2019

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Oct 10, 2019

We don't support "local" replications in 3.x so there is not need to waste resources creating this db on every node, and then continuously listening for replication doc updates from it.

We don't support "local" replications in 3.x so there is not need to waste
resources creating this db on every node, and then continuously listening for
replication doc updates from it.
@nickva nickva force-pushed the dont-auto-create-node-local-replicator-db branch from f05e454 to 154906f Compare October 10, 2019 15:53
@rnewson rnewson self-requested a review October 10, 2019 16:05
Copy link
Member

@rnewson rnewson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #1523 issue, the node-local _replicator db is gone in 3.0 anyway. +1.

@nickva nickva merged commit 28edf6a into master Oct 10, 2019
@nickva nickva deleted the dont-auto-create-node-local-replicator-db branch October 10, 2019 19:05
@wohali
Copy link
Member

wohali commented Jan 15, 2020

@nickva Wondering if we should have a process in 3.0 that finds these and destroys them so that upgraded nodes/clusters can avoid doing unnecessary work. Or do we already ignore those with these code deletions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants