Fauxton: fix fauxton query parameters for complex keys (COUCHDB-2249) #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing! Have a question to the comments at the bottom of the tests, beside this, awesome stuff so far. |
Ensure we clone the parameters to Documents.QueryParams.parse and Documents.QueryParams.stringify. These functions should return new data structures rather than modifying the input in-place.
Do not use the parsed query object for url generation. Instead, use the stringified representation. Fixes COUCHDB-2249.
|
@robertkowalski Those comments / placeholders should not have slipped in - now fixed :) |
|
Thanks @willholley, I've merged in. |
|
You can close the ticket |
lag-linaro
pushed a commit
to lag-linaro/couchdb
that referenced
this pull request
Oct 25, 2018
Add partial support for Erlang/OTP 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix URL generation in Fauxton when complex keys are specified as query parameters (COUCHDB-2249).
This PR contains two changes: