1259 stable replication ids #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - one question is why we only try to use the server uuid if the port is in some configurable dynamic range? Why not check for the server uuid and always use that if it exists. |
|
That's deliberate, I didn't want to make the extra http call if it's not strictly necessary, but perhaps I've over-optimized? I would really like to hear opinions on my choice of {Scheme, UserInfo, UUID, Path} if the UUID is used. Could it just be UUID on its own? The other checkpoints include the full url, and so vary based on scheme, hostname, port, userinfo and path, but is it necessary? |
cararemixed
pushed a commit
to cararemixed/couchdb
that referenced
this pull request
Dec 9, 2014
Support for printing bitstrings (reported by @freeaakk)
candeira
pushed a commit
to candeira/couchdb
that referenced
this pull request
Apr 6, 2015
This closes apache#35 COUCHDB-2547
nickva
pushed a commit
to cloudant/couchdb
that referenced
this pull request
Apr 21, 2017
This closes apache#35 Signed-off-by: ILYA Khlopotov <iilyak@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a server-wide UUID if port is unstable
COUCHDB-1259