Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle request processes exiting with {shutdown, Error} #4013

Merged
merged 1 commit into from
May 6, 2022

Conversation

nickva
Copy link
Contributor

@nickva nickva commented May 2, 2022

Previously on error they exited normal, and now exit with the {shutdown, Error} reason.

See: mochi/mochiweb@e56a4dc

@nickva nickva changed the title See how mochiweb with shutdown exit resons would work See how mochiweb with shutdown exit reson would work May 3, 2022
@nickva nickva marked this pull request as ready for review May 5, 2022 22:31
@nickva nickva force-pushed the mochiweb-with-shutdown-exits branch from 7a0b15d to ed3c670 Compare May 5, 2022 22:31
@nickva nickva changed the title See how mochiweb with shutdown exit reson would work Handle request processes exiting with {shutdown, Error} instead of normal May 5, 2022
@nickva nickva changed the title Handle request processes exiting with {shutdown, Error} instead of normal Handle request processes exiting with {shutdown, Error} May 5, 2022
Previously on error they exited `normal`, and now exit with the `{shutdown, Error}`
reason.

See: mochi/mochiweb@e56a4dc
@nickva nickva force-pushed the mochiweb-with-shutdown-exits branch from ed3c670 to 3184f1b Compare May 5, 2022 23:24
Copy link
Contributor

@jaydoane jaydoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickva nickva merged commit b91ec0b into 3.x May 6, 2022
@nickva nickva deleted the mochiweb-with-shutdown-exits branch May 6, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants