New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate docs into the main repo #4164
Conversation
3331d70
to
48a312d
Compare
34b0115
to
e0736f9
Compare
If docs are changed then docs "check" is run If only docs changed and not other files, then only docs are built and other stages are "fast-forwarded". Also, remove docs from gitignore and from rebar.config.
e0736f9
to
dd45360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Nick!
Some informational reminders:
- Are all tags set in main like in docs-main
- Change link in RTD
- Document change in couchdb-documentation
- Archive couchdb-documentation?
- Any links to update?
- Any open PR’s need to get merged first?
- Something I forgot?
Good points, @big-r81 RTD allows configuring which branches/tags to build. I think we could keep As for archiving we could just update the main branch and put just a readme file indicating to move the pull request to the main repo.. After some time we can archive it too. Unfortunately the pending PRs would have to be re-targeted for the main repo. I think there would be some links / example readme changes. |
This branch contains the 3.2.2 version of the docs but migrated to the main CouchDB repo. After switching the URL repo in RDT we want to make sure we still display the stable (aliased to 3.2.2) docs in RDT not just the latest ones. Main integration PR #4164
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few comments, but it appears I was too late!
Maybe it’s a good idea to define an .editorconfig for the project / projects? |
It’s never too late! Will fix it in a separate PR. Thanks for taking a look, @jaydoane |
I tried this in
I'll reformat both the full and pr files |
As per comment in #4164 (comment)
As per comment in #4164 (comment)
I wonder if emacs could read that? For erlang it's relatively straightforward as we're using erlfmt but for other languages it's a bit unspecified. |
|
As per comment in #4164 (comment)
Related to the discussion in dev ML
The main advantage for doing it are:
./configure
as there one less dependency to fetch.One of the objections of this approach, as discussed in the ML, was that docs PRs have a lightweight CI and we'd want to preserve that. This PR attempts to address that with the changes to the
Jenkinsfile.pr
(thanks to @big-r81 for the idea in the ML) where the following logic is used in thewhen ...
stage triggers.make check
(a quick format check for docs)make
is run, like in the previous separate docs repo. All the other CI steps are skipped.make dist
also builds docs. If this happens there is not need to also run the "Build Docs" so that can be skipped.