Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate config app into main repo #4242

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Integrate config app into main repo #4242

merged 1 commit into from
Oct 26, 2022

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Oct 26, 2022

@nickva nickva requested a review from jaydoane October 26, 2022 06:11
@nickva
Copy link
Contributor Author

nickva commented Oct 26, 2022

Note: that in order to pass the main Jenkins CI had to reformat it the code with erlfmt before committing.

@nickva nickva force-pushed the integrate-config branch 2 times, most recently from 5b79a50 to 5cd5f96 Compare October 26, 2022 07:17
big-r81
big-r81 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickva nickva merged commit 8a71e3d into main Oct 26, 2022
@nickva nickva deleted the integrate-config branch October 26, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-r81 big-r81 big-r81 approved these changes

@jaydoane jaydoane Awaiting requested review from jaydoane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickva @big-r81