JWT: require valid exp claim by default
#5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
jwt-exp-by-default
branch
2 times, most recently
from
b8a8e79
to
e87c731
Compare
rnewson
force-pushed
the
jwt-exp-by-default
branch
2 times, most recently
from
83655f4
to
1d48c78
Compare
Users of JWT rightly expect tokens to be considered invalid once they expire. It is a surprise to some that this requires a change to the default configuration. In the interest of security we will now require a valid `exp` claim in tokens. Administrators can disable the check by changing `required_claims` back to the empty string. We do not add `nbf` as a required claim as it seems to not be set often in practice. closes #5046
rnewson
force-pushed
the
jwt-exp-by-default
branch
from
1d48c78
to
3aa3f1d
Compare
nickva
approved these changes
May 16, 2024
big-r81
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Users of JWT rightly expect tokens to be considered invalid once they expire. It is a surprise to some that this requires a change to the default configuration. In the interest of security we will now require a valid
expclaim in tokens. Administrators can disable the check by changingrequired_claimsback to the empty string.We do not add
nbfas a required claim as it seems to not be set often in practice.Testing recommendations
N/A
Related Issues or Pull Requests
#5046
Checklist
rel/overlay/etc/default.inisrc/docsfolder