Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS test cleanup x3 #651

Merged
merged 3 commits into from Jul 7, 2017
Merged

JS test cleanup x3 #651

merged 3 commits into from Jul 7, 2017

Conversation

wohali
Copy link
Member

@wohali wohali commented Jul 7, 2017

Overview

This PR includes 3 small commits to fix up the JS test suite:

  1. Really, truly disable the compaction daemon. (The previous approach wasn't working.)
  2. Ensure that every JS test cleans up after itself, removing all old databases before exiting.
  3. Disable the flaky stats.js test, which needs a complete rewrite to make sense. It was my fault re-enabling it even partially for 2.0. Sorry.

Testing recommendations

make javascript and look for all passes.

@wohali wohali requested a review from janl July 7, 2017 07:24
@rnewson rnewson self-requested a review July 7, 2017 16:37
@wohali wohali merged commit a1b5e13 into master Jul 7, 2017
@wohali wohali deleted the fix-js-tests branch July 7, 2017 16:38
@wohali wohali removed the request for review from janl July 7, 2017 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnewson rnewson rnewson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wohali @rnewson