RAT-369: Issue errors but do not fail the build in order to work incr…

…ementally
apache · Apr 21, 2024 · 191b119 · 191b119
1 parent 7fee5e2
commit 191b119
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ignore/GlobIgnoreMatcher.java b/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ignore/GlobIgnoreMatcher.java
@@ -78,7 +78,7 @@ public void loadFile(final Log log, final File scmIgnore) {
         if (scmIgnore != null && scmIgnore.exists() && scmIgnore.isFile()) {
             log.debug("Parsing exclusions from " + scmIgnore);
 
-            try (BufferedReader reader = new BufferedReader(new FileReader(scmIgnore, StandardCharsets.UTF_8))) {
+            try (BufferedReader reader = new BufferedReader(new FileReader(scmIgnore))) {
                 String line;
                 while ((line = reader.readLine()) != null) {
                     if (!isComment(line)) {

diff --git a/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java b/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java
@@ -297,7 +297,7 @@ public LicenseSetFactory.LicenseFilter internalFilter() {
     private class Logger implements Log {
 
         private void write(int level, String msg) {
-            try (PrintWriter pw = new PrintWriter(new LogOutputStream(Report.this, level), false, StandardCharsets.UTF_8))
+            try (PrintWriter pw = new PrintWriter(new LogOutputStream(Report.this, level)))
             {
                pw.write(msg);
             }

diff --git a/pom.xml b/pom.xml
@@ -306,6 +306,8 @@ agnostic home for software distribution comprehension and audit tools.
           <artifactId>spotbugs-maven-plugin</artifactId>
           <version>4.8.4.0</version>
           <configuration>
+            <!-- TODO remove after RAT-369 is done -->
+            <failOnError>false</failOnError>
             <!--includeFilterFile>spotbugs-security-include.xml</includeFilterFile>
                   <excludeFilterFile>spotbugs-security-exclude.xml</excludeFilterFile-->
             <plugins>