RAT-314: integration test for .mvn default exclusion after release of v0.16

[ottlinger]

This branch tries to integrate an integration test that shows any future regression in defining the exclusion on .mvn folders.

2023-01-30

As of now this branch will not build as we consume a previous RAT version during the RAT build.
Therefore the branch works on a future SNAPSHOT version and references the current 0.16-SNAPSHOT available after RAT-314 was closed.

[Claudenw]

@ottlinger What is the status of this change?

[ottlinger]

@Claudenw I hope to find some time on the weekend to get this in proper shape - sry 4 d delay

[Claudenw]

No worries. Was wondering if i could help.

…

On Fri 10 May 2024, 12:49 P. Ottlinger, ***@***.***> wrote: @Claudenw <https://github.com/Claudenw> I hope to find some time on the weekend to get this in proper shape - sry 4 d delay — Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASTVHWA7FV5A23MOVLLAITZBSQ3PAVCNFSM6AAAAAAULHHRWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGM4TENBUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ottlinger]

No worries. Was wondering if i could help.
…
On Fri 10 May 2024, 12:49 P. Ottlinger, @.> wrote: @Claudenw https://github.com/Claudenw I hope to find some time on the weekend to get this in proper shape - sry 4 d delay — Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASTVHWA7FV5A23MOVLLAITZBSQ3PAVCNFSM6AAAAAAULHHRWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGM4TENBUGQ . You are receiving this because you were mentioned.Message ID: @.>

Thanks - I just wanted to know how this is done, which is why I left this for me :)

[Claudenw]

There is code in the Maven plugin for ScmIgnoreParser and ExclusionHelper that handle exclusions. that needs to be brought into core so that CLI and Ant can use it too. Perhaps think about adding configuration files for SCMs that list the excluded things and then read them on demand (like we do for internal style sheets). The configuration file could have the same structure as a gitignore file. Then we can use the .gitignore processor we already have to read them and generate the file and directory exclusion filters.

I know that this is more than you were looking to do but it fits with the harmonization epic we have. I can help get the command line to work with it if you would like.

[ottlinger]

There is code in the Maven plugin for ScmIgnoreParser and ExclusionHelper that handle exclusions. that needs to be brought into core so that CLI and Ant can use it too. Perhaps think about adding configuration files for SCMs that list the excluded things and then read them on demand (like we do for internal style sheets). The configuration file could have the same structure as a gitignore file. Then we can use the .gitignore processor we already have to read them and generate the file and directory exclusion filters.

I know that this is more than you were looking to do but it fits with the harmonization epic we have. I can help get the command line to work with it if you would like.

I see your point but I'm not sure if the maven-specific invoker-plugin-test environment can be put into the other submodule. I always understood it to be a part of the maven plugin itself and no common functionality.

[Claudenw]

Looks to me.

Tested with mvn verify so everything seem to work.

[ottlinger]

@Claudenw I'll merge this change in. Concerning the cleanup of testing infrastructure I fear there is more to it, as we have

• unit tests (above mentioned Parsertests)
• Java integration tests
• Maven invoker integration tests

All of them seem to cover different parts of the "RAT beast" ;)