RAT-190: Fixes for minor bugs that blocked problem detection #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudenw
force-pushed
the
RAT-190_js_not_parsed
branch
from
d116ccb
to
5b5f37f
Compare
Claudenw
force-pushed
the
RAT-190_js_not_parsed
branch
from
5b5f37f
to
0c41c9c
Compare
ottlinger
reviewed
May 11, 2024
| return new ClaimReporterMultiplexer(configuration.isDryRun(), analysisMultiplexer, reporters); | ||
| return new ClaimReporterMultiplexer(writer, configuration.isDryRun(), analysisMultiplexer, reporters); | ||
| } | ||
|
|
There was a problem hiding this comment.
LHF: Pls reformat this class.
There was a problem hiding this comment.
LHF? what does that mean?
There was a problem hiding this comment.
Sry, Low Hanging Fruit (LHF) - I use this abbreviation in commits or reviews in case of minor details or simple things.
ottlinger
approved these changes
May 11, 2024
ottlinger
reviewed
May 11, 2024
| @@ -160,7 +160,7 @@ public String desc() { | |||
| * Name of File to exclude from report consideration. | |||
| */ | |||
| static final Option EXCLUDE_CLI = Option.builder("e").longOpt("exclude").hasArgs().argName("Expression") | |||
| .desc("Excludes files matching wildcard <expression>. May be followed by multiple arguments. " | |||
| .desc("Excludes files matching wildcard <Expression>. May be followed by multiple arguments. " | |||
There was a problem hiding this comment.
Pls update the site template to keep its text in sync with the stuff in the code. Should we add a javadoc in this class on where to keep it in sync with in case of changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is dependant upon #246 and should not be merged until that one is merged.
This is not a fix for Rat-190 as that issue was solved with the Tika introduction.
This change fixes some issues with the current source code.