-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected #252
RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected #252
Conversation
c8cdfaf
to
8f8b8f5
Compare
I don't like the fix for the test errors, but there seems to be no other way. I was planning on resolving more spotbugs before merging but this at least has the tests and many of the spotbugs resolved. |
apache-rat-core/src/main/java/org/apache/rat/license/SimpleLicense.java
Outdated
Show resolved
Hide resolved
Thanks for your work and a cool catch solving RAT-265 on the way! :) |
I need to resolve some conflicts. I'll try to get to that today/this evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explicitly referencing RAT-265 and adding test cases.
fixed RAT-265
Added initial tests for command line processing