RAT-234: Support TypeScript .ts files #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…must be tasted to determine if it is binary
ajbanck
changed the title
|
@ajbanck Are you the reporter of RAT-234? Did you sign a ContributorLicenseAgreement so we can properly add your patch to the official RAT? https://www.apache.org/licenses/icla.pdf Thanks for your help and usage of RAT :-) |
|
@ottlinger I am not the reporter of RAT-234. Didn't want to create a duplicate so used the existing ticket. |
|
@ajbanck applied as https://svn.apache.org/r1817859 Thanks for your contribution and help! |
asfgit
pushed a commit
that referenced
this pull request
Jan 10, 2018
TypeScript files are just excluded, relates to: #7 Thanks to ajbanck git-svn-id: https://svn.apache.org/repos/asf/creadur/rat/trunk@1817859 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAT-234: The .ts extension is marked as binary as it is a common extension for datastream video files.
The .ts extension is used for TypeScript files so the .ts extension can't be use to determine the file content.
Removed TS from DATA_EXTENSIONS so .ts files are tested to determine the content