This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Suggested code changes from Coverity inspection #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn nonnegative values and is caught by the masking anyway
|
Thanks Sean! +1, apart from the few small comments I added. No problem with the hash partitioning changes, there's no need to maintain the same partitioning over releases. Probably best to stick this in a JIRA though (that's the typical flow for Crunch). |
|
Done, I think I addressed those in the commit just now. |
|
Looks good. I created https://issues.apache.org/jira/browse/CRUNCH-380 for this in jira. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://scan.coverity.com/projects/1983
These should be small uncontroversial changes. Look at the hashCode-related change though, in case it's important to retain the exact partitioning across releases.
(Does this need a JIRA?)