Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ClassNotFoundException org.hsql.jdbcDriver #47

Merged
merged 3 commits into from Feb 17, 2020
Merged

fix ClassNotFoundException org.hsql.jdbcDriver #47

merged 3 commits into from Feb 17, 2020

Conversation

jim-wei
Copy link
Contributor

@jim-wei jim-wei commented Feb 8, 2020

fix ClassNotFoundException org.hsql.jdbcDriver, when packaging with 'mvn clean install -Prealm-a' and running in tomcat container.
dependency org.hsqldb may be lost.

…mvn clean install -Prealm-a' and running in tomcat container
Copy link
Contributor

@coheigea coheigea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this dependency should apply for all of the profiles.

@jim-wei
Copy link
Contributor Author

jim-wei commented Feb 14, 2020

I guess this dependency should apply for all of the profiles.

I totally agree with you.
add hsqldb dependencies to all idp-service profiles
commit is already pushed.

@coheigea
Copy link
Contributor

Actually, sorry, I'd prefer to only add this dependnecy for the "profile A" and "profile B" and "standalone" cases. For the default case, I'd prefer if it was not added, as it would get added into the distribution binary in this case.

@jim-wei
Copy link
Contributor Author

jim-wei commented Feb 17, 2020

sorry,I did not consider binary case. Thanks for reminding.

@coheigea coheigea merged commit 3278d63 into apache:1.4.x-fixes Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants