CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE) #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
force-pushed
the
CXF-8758
branch
2 times, most recently
from
9b0060f
to
5615db6
Compare
jimma
reviewed
Jan 9, 2023
| <dependency> | ||
| <groupId>com.github.tomakehurst</groupId> | ||
| <artifactId>wiremock-standalone</artifactId> | ||
| <version>2.27.2</version> |
There was a problem hiding this comment.
@reta Very minor thing : can this be upgraded to 2.35.0 ? From https://github.com/automatictester/wiremock-maven-plugin/releases, it looks 7.3.0 can work with 2.35.0.
There was a problem hiding this comment.
@jimma totally makes sense, thank you. The end goal is to use wiremock 3.0.0 but sadly microprofile-rest-client-tck still depends on javax.servlet [1], I was thinking of submitting the pull request there first (since we already have wiremock beta release).
jimma
approved these changes
Jan 9, 2023
reta
force-pushed
the
CXF-8758
branch
5 times, most recently
from
47f4b4f
to
05649f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration path for Wiremock (Jetty 11/JakartaEE)