Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXF-7455] Tolerate missing message part #297

Open
wants to merge 1 commit into
base: 3.1.x-fixes
Choose a base branch
from

Conversation

semancik
Copy link

No description provided.

@deki
Copy link
Contributor

deki commented Jul 27, 2017

Thanks for your pull request. Can you provide a unit/ integration test for this?

@semancik
Copy link
Author

Looks like this has been already worked around in the winrm4j project. I was not aware of that. So I might actually cancel the pull request later on. Please, bear with me, I need some time to explore. However, I would say that it is rather sad that it is easier to work around the problem than to deal with all this checkstyle pain, unit tests and so on.

@deki
Copy link
Contributor

deki commented Jul 27, 2017

No need to cancel the PR, if we could make the code more robust, we should do that.

@semancik
Copy link
Author

I was looking around how to construct a test for this. But I'm really puzzled. There seems to be very little documentation about writing tests. And I could not find any test that would be similar to what I'm trying to do.

I have SOAP message that is causing the exception. It is a SOAP response from the server. How do I create a simple test that just attempts to process the message, runs the interceptors and checks the processed message?

@deki
Copy link
Contributor

deki commented Aug 23, 2017

Ok could you please attach the SOAP message to the JIRA issue?

Regarding test you can take a look at the existing org.apache.cxf.jaxws.holder.HolderTest.

Btw. PRs should usually point to master, we will take care of merging them to the other branches.

@deki
Copy link
Contributor

deki commented Jun 5, 2018

@semancik any chance to get the SOAP message that reproduces the issue?

@semancik
Copy link
Author

semancik commented Jun 6, 2018

I'm sorry. I was lucky enough not to be forced to deal with that terrible Microsoft technology in the meantime. And I'm quite scared to look there just by myself unless I really have to. Please bear with me. But I'll do it ... sooner or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants