StringUtils: lazy Pattern evaluation #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
reviewed
Oct 24, 2018
| return getPattern(regex).splitAsStream(s); | ||
| } | ||
| static Pattern getPattern(String regex) { | ||
| return Optional.ofNullable(PATTERN_MAP.get(regex)).orElseGet(() -> Pattern.compile(regex)); |
There was a problem hiding this comment.
May be we could use PATTERN_MAP.computeIfAbsent(regex, key -> Pattern.compile(key));?
|
I will recheck this method usage; some cases can be switched to String.split fastpath way |
amarkevich
pushed a commit
to amarkevich/cxf
that referenced
this pull request
Dec 5, 2018
amarkevich
pushed a commit
that referenced
this pull request
Dec 6, 2018
* String.split via fastpath instead of precompiled Pattern * Deprecate some StringUtils.split; computeIfAbsent required one (#465) * finalize; the only place is HttpHeadersImpl due to COOKIE_SEPARATOR_CRLF
rmannibucau
pushed a commit
to rmannibucau/cxf
that referenced
this pull request
Mar 18, 2019
* String.split via fastpath instead of precompiled Pattern * Deprecate some StringUtils.split; computeIfAbsent required one (apache#465) * finalize; the only place is HttpHeadersImpl due to COOKIE_SEPARATOR_CRLF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/36742258/map-getordefault-vs-getorusesupplier