Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXF-7996] Fix @Encode TCK test #778

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

andymc12
Copy link
Contributor

This should fix the following Jakarta RESTful WS TCK failures:

com/sun/ts/tests/jaxrs/ee/rs/beanparam/form/plain/JAXRSClient.java#formFieldParamEntityWithEncodedTest_from_standalone: JAXRSClient_formFieldParamEntityWithEncodedTest_from_standalone

com/sun/ts/tests/jaxrs/ee/rs/beanparam/form/plain/JAXRSClient.java#formParamEntityWithEncodedTest_from_standalone: JAXRSClient_formParamEntityWithEncodedTest_from_standalone

The issue is that (prior to this fix) form parameters are read into a map as either decoded or encoded based on whether the first parameter has the @Encoded annotation or not. This can result in the @Encoded annotation on second or subsequent parameters getting ignored.

The fix is to read the parameters into the map without performing any decoding until it is determined which parameters should be decoded.

Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>
@andymc12 andymc12 requested a review from reta April 14, 2021 02:33
@andymc12 andymc12 self-assigned this Apr 14, 2021
Copy link
Member

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the problem now, thanks a lot for the fix @andymc12 !

@andymc12 andymc12 merged commit 70133ba into apache:master Apr 16, 2021
@andymc12
Copy link
Contributor Author

@dblevins
Copy link
Contributor

Thank you @andymc12 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants