[CXF-8594]:Fix regular expression parameter with non-capturing group … #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
reviewed
Sep 8, 2021
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java
Outdated
Show resolved
Hide resolved
reta
approved these changes
Sep 9, 2021
|
@jimma this one could be integrated, right? |
|
@reta what do you mean by integrated ? |
|
@jimma oh sorry, I meant - merged |
|
@reta Sure. All tests are passed, and it's ready to merge. |
|
Thanks @jimma , I think you could merge it, right? Or you prefer me to merge and backport it? Thanks! |
|
@reta If you get time today to merge and backport , please give it go. Otherwise I'll back to look tomorrow morning. |
reta
pushed a commit
that referenced
this pull request
Sep 14, 2021
#847) * [CXF-8594]:Fix regular expression parameter with non-capturing group doesn't work * [CXF-8594]:Improve the fix to better check the non grouping expression
reta
pushed a commit
that referenced
this pull request
Sep 14, 2021
#847) * [CXF-8594]:Fix regular expression parameter with non-capturing group doesn't work * [CXF-8594]:Improve the fix to better check the non grouping expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…doesn't work