Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXF-8648] Make ClaimsAuthorizingInterceptor configurable in ClaimsAu… #899

Merged
merged 1 commit into from Feb 3, 2022

Conversation

olwulff
Copy link
Contributor

@olwulff olwulff commented Feb 3, 2022

…thorizingFilter

I've deprecated the setters on ClaimsAuthorizingFilter which are a wrapper on the inner bean only. Instead, the inner bean can now be configured on its own and assigned to the ClaimsAuthorizingFilter

@olwulff olwulff marked this pull request as draft February 3, 2022 08:26
@olwulff olwulff marked this pull request as ready for review February 3, 2022 08:27
@olwulff
Copy link
Contributor Author

olwulff commented Feb 3, 2022

@coheigea Not sure why there is a code scanning error. I don't see a relation to the changes.

@coheigea
Copy link
Contributor

coheigea commented Feb 3, 2022

It's OK @olwulff, we can ignore that error.

@olwulff olwulff closed this Feb 3, 2022
@olwulff olwulff reopened this Feb 3, 2022
@olwulff
Copy link
Contributor Author

olwulff commented Feb 3, 2022

Will @coheigea merge this PR?

I'll create a second PR for the 3.5 branch. I assume I can't mark the two setters as deprecated within a patch version. Right?

@coheigea
Copy link
Contributor

coheigea commented Feb 3, 2022

Don't bother creating a second PR, I'll just cherry-pick it

@coheigea coheigea merged commit c76c75b into apache:master Feb 3, 2022
coheigea pushed a commit that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants