Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXF-8668]:Set SniHostCheck to false for SSLNettyClientTest #918

Merged
merged 1 commit into from Apr 7, 2022

Conversation

jimma
Copy link
Contributor

@jimma jimma commented Mar 4, 2022

No description provided.

@@ -31,7 +31,7 @@
<bean class="org.springframework.context.support.PropertySourcesPlaceholderConfigurer"/>
<httpj:engine-factory>
<httpj:engine port="${SSLNettyClientTest.port}">
<httpj:tlsServerParameters>
<httpj:tlsServerParameters sniHostCheck="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false is the default, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta Sorry for long delay, I missed this comment. Yes, false is the default for backward compatibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np at all, 👍

@coheigea
Copy link
Contributor

coheigea commented Apr 7, 2022

@jimma Can we merge this and close the JIRA?

@jimma jimma merged commit 76d1ca9 into apache:master Apr 7, 2022
@jimma
Copy link
Contributor Author

jimma commented Apr 7, 2022

@coheigea I already merged it and closed JIRA. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants