Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daffodil 1884 bit order #34

Merged
merged 1 commit into from Feb 8, 2018

Commits on Feb 8, 2018

  1. Fix unparser interactions of bitOrder with suspensions/splits.

    Call ustate.bitOrder after each term unparser.
    setPriorBitOrder in a few places where it was missing.
    
    This corrects an oversight where the unparser was not modified to handle
    bit order changes properly. Because few data formats change bit orders
    in the middle of data, this error went unrecognized until it was
    discovered in NACT Link16 data where the NACT envelope is MSBF, but the
    Link16 payload is LSBF.
    
    Test bitOrderOVC1 exercises changing bit orders where a bit order change
    occurs, on a byte boundary, but alignment fill is inserted before to
    fill a partial byte. The alignment fill for the fragment byte must be
    LSBF even though the element having that alignment fill is MSBF.
    
    The tests test_ep1 and test_ep2 are also envelope-payload tests with BE MSBF
    envelop and LE LSBF payloads.
    
    DAFFODIL-1884
    mbeckerle committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    6654c6b View commit details
    Browse the repository at this point in the history