Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
leoluan2009 committed Jun 16, 2024
1 parent a1c8011 commit e8cf62b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -717,11 +717,11 @@ class CometSparkSessionExtensions
}

case op: CartesianProductExec if !isCometOperatorEnabled(conf, "cross_join") =>
withInfo(op, "Cross_Join is not enabled")
withInfo(op, "Cross join is not enabled")
op

case op: CartesianProductExec if !op.children.forall(isCometNative(_)) =>
withInfo(op, "Cross_Join disabled because not all child plans are native")
withInfo(op, "Cross join disabled because not all child plans are native")
op

case op =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2607,14 +2607,14 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
case join: CartesianProductExec if isCometOperatorEnabled(op.conf, "cross_join") =>
// TODO: Support CartesianProductExec with join condition after new DataFusion release
if (join.condition.isDefined) {
withInfo(op, "Cross_Join with a join condition is not supported")
withInfo(op, "Cross join with a join condition is not supported")
return None
}
val joinBuilder = OperatorOuterClass.CrossJoin.newBuilder()
Some(result.setCrossJoin(joinBuilder).build())

case join: CartesianProductExec if !isCometOperatorEnabled(op.conf, "cross_join") =>
withInfo(join, "Cross_Join is not enabled")
withInfo(join, "Cross join is not enabled")
None

case op if isCometSink(op) && op.output.forall(a => supportedDataType(a.dataType)) =>
Expand Down

0 comments on commit e8cf62b

Please sign in to comment.