Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for supported types of SortMergeJoin in DataFusion #357

Open
viirya opened this issue May 1, 2024 · 1 comment
Open

Add a test for supported types of SortMergeJoin in DataFusion #357

viirya opened this issue May 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented May 1, 2024

What is the problem the feature request solves?

From planga82's comment: #355 (comment)

As an idea, I was thinking that we could put in tests to check the supported types in Datafusion, so that when we upgrade to a version of datafusion that supports these other types (like timestamp with timezone for example) we are aware that we should change the list of allowed types.

Describe the potential solution

No response

Additional context

No response
@viirya viirya added the enhancement New feature or request label May 1, 2024
@planga82
Copy link
Contributor

planga82 commented May 1, 2024

I'm working on it

@planga82 planga82 mentioned this issue May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add a test for supported types of SortMergeJoin in DataFusion planga82/datafusion-comet
2 participants
@viirya @planga82